fix: Honor noproxy and skip proxying if ddsite is in the noproxy list #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514 by checking if NO_PROXY contains DD_SITE domain, and the the user is likely relying on privatelink endpoints + private DNS isntead of an HTTP proxy for telemetry data.
This is kind of a hack in 2 ways:
reqwesthas some support for NO_PROXY buthyper-proxydoesn't. I could use the built in version, but either way I'd need to build it myselfThis solution works for the customer reporting it, as their NO_PROXY string includes
datadoghq.com.But I wonder if there's a use case for a customer who would use privatelink for, say metrics only - but then use an HTTP proxy for logs (perhaps to inspect logs for PII or some other form of compliance).
In that case our entire shared http client architecture (complete with shared threadpools) would need to change. I think we should leave that for the future at this time, and help our friends in #514 move on.
Screenshots of my config:

VPC endpoints as per our docs:

Logs/metrics/traces:


